Resolve "Fix Buttons in header are not flat when viewport spinner is visible" #99

Merged
ariktaurendil merged 9 commits from 41-fix-buttons-in-header-are-not-flat-when-viewport-spinner-is-visible into master 2026-04-24 06:17:34 -03:00
ariktaurendil commented 2026-04-24 02:32:25 -03:00 (Migrated from gitlab.com)

Closes #41

Closes #41
ariktaurendil commented 2026-04-24 02:32:26 -03:00 (Migrated from gitlab.com)

requested review from @tarmaciltur

requested review from @tarmaciltur
ariktaurendil commented 2026-04-24 02:32:26 -03:00 (Migrated from gitlab.com)

assigned to @ariktaurendil

assigned to @ariktaurendil
ariktaurendil commented 2026-04-24 03:42:50 -03:00 (Migrated from gitlab.com)

marked this merge request as ready

marked this merge request as **ready**
ariktaurendil commented 2026-04-24 05:44:00 -03:00 (Migrated from gitlab.com)

added 5 commits

  • c072cc14 - viewport.vala: removes on_spinner_visible_changed callback
  • cea28296 - viewport.vala: adds viewport_ready signal.
  • 3a3730cf - viewport.vala: set_ready emits viewport_ready signal.
  • 4a449dd2 - window.vala: changes change_top_bar_style
  • fe1a62b2 - windows.vala: conncets and disconnects viewport_ready

Compare with previous version

added 5 commits <ul><li>c072cc14 - viewport.vala: removes on_spinner_visible_changed callback</li><li>cea28296 - viewport.vala: adds viewport_ready signal.</li><li>3a3730cf - viewport.vala: set_ready emits viewport_ready signal.</li><li>4a449dd2 - window.vala: changes change_top_bar_style</li><li>fe1a62b2 - windows.vala: conncets and disconnects viewport_ready</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/52/diffs?diff_id=1767241437&start_sha=f12f5a5f1ab551441902bfca9ec807dcc90d77f2)
ariktaurendil commented 2026-04-24 06:13:57 -03:00 (Migrated from gitlab.com)

added 4 commits

  • 616f8c82 - window.vala: adds disconnect_viewport_ready method
  • 625ed216 - window.vala: viewport_ready signal is diconnected with disconnect_viewport_ready
  • 53b99d14 - viewport.vala: adds emit_viewport_ready method
  • a4c02307 - window.vala: change_displayed_camera emits viewport.Viewport_ready signal

Compare with previous version

added 4 commits <ul><li>616f8c82 - window.vala: adds disconnect_viewport_ready method</li><li>625ed216 - window.vala: viewport_ready signal is diconnected with disconnect_viewport_ready</li><li>53b99d14 - viewport.vala: adds emit_viewport_ready method</li><li>a4c02307 - window.vala: change_displayed_camera emits viewport.Viewport_ready signal</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/52/diffs?diff_id=1767299947&start_sha=fe1a62b2361fe50f3bc0bc5484ae4f290e9c7614)
tarmaciltur commented 2026-04-24 06:17:34 -03:00 (Migrated from gitlab.com)

mentioned in commit 89fff51c8a

mentioned in commit 89fff51c8a8686a188bd5ab65c2d34c7efc63065
tarmaciltur (Migrated from gitlab.com) merged commit 89fff51c8a into master 2026-04-24 06:17:35 -03:00
Sign in to join this conversation.
No reviewers
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/vigilantear!99
No description provided.