Resolve "Buttons in header are not flat when viewport spinner is visible" #97

Merged

ariktaurendil merged 3 commits from 40-bunttons-in-headeb-are-not-flat-when-viewport-spinner-is-visible into master 2026-04-22 17:21:40 -03:00

Conversation 14 Commits 3 Files changed 4 +18 -1

ariktaurendil commented 2026-04-11 22:35:58 -03:00 (Migrated from gitlab.com)

Copy link

{width=900 height=526}

Closes #40

{width=900 height=526} Closes #40

ariktaurendil commented 2026-04-11 22:35:58 -03:00 (Migrated from gitlab.com)

Copy link

requested review from @tarmaciltur

requested review from @tarmaciltur

ariktaurendil commented 2026-04-11 22:35:58 -03:00 (Migrated from gitlab.com)

Copy link

assigned to @ariktaurendil

assigned to @ariktaurendil

ariktaurendil commented 2026-04-11 22:47:55 -03:00 (Migrated from gitlab.com)

Copy link

added 3 commits

• 396c1d07 - window.vala: adds change_top_bar_style method
• 8144e948 - window.blp: sets header_bar style main-headerbar-settings as default
• 6924ba68 - Viewport: adds on_spinner_visible_changed callback

Compare with previous version

added 3 commits <ul><li>396c1d07 - window.vala: adds change_top_bar_style method</li><li>8144e948 - window.blp: sets header_bar style main-headerbar-settings as default</li><li>6924ba68 - Viewport: adds on_spinner_visible_changed callback</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/50/diffs?diff_id=1746323553&start_sha=7ff98fac921f937784455c78a5b6c6f59aaccee2)

ariktaurendil commented 2026-04-11 22:48:41 -03:00 (Migrated from gitlab.com)

Copy link

changed the description

changed the description

tarmaciltur commented 2026-04-12 13:16:01 -03:00 (Migrated from gitlab.com)

Copy link

changed title from Draft: Resolve "Bunttons in headeb are not flat when viewport spinner is visible" to Draft: Resolve "Buttons in header are not flat when viewport spinner is visible"

<p>changed title from <code class="idiff">Draft: Resolve &quot;Bu<span class="idiff left deletion">n</span>ttons in heade<span class="idiff right deletion">b</span> are not flat when viewport spinner is visible&quot;</code> to <code class="idiff">Draft: Resolve &quot;Buttons in heade<span class="idiff left right addition">r</span> are not flat when viewport spinner is visible&quot;</code></p>

tarmaciltur commented 2026-04-12 13:42:28 -03:00 (Migrated from gitlab.com)

Copy link

{width=827 height=600}

{width=827 height=600}

ariktaurendil commented 2026-04-12 22:40:16 -03:00 (Migrated from gitlab.com)

Copy link

Can't reproduce it.

Can't reproduce it.

ariktaurendil commented 2026-04-12 22:40:49 -03:00 (Migrated from gitlab.com)

Copy link

This needs more work, indeed.

This needs more work, indeed.

ariktaurendil commented 2026-04-12 23:22:28 -03:00 (Migrated from gitlab.com)

Copy link

added 5 commits

• 6924ba68...7a7b0eb4 - 2 commits from branch master
• ae24573d - window.vala: adds change_top_bar_style method
• 28efc6d3 - window.blp: sets header_bar style main-headerbar-settings as default
• 0da0edea - Viewport: adds on_spinner_visible_changed callback

Compare with previous version

added 5 commits <ul><li>6924ba68...7a7b0eb4 - 2 commits from branch <code>master</code></li><li>ae24573d - window.vala: adds change_top_bar_style method</li><li>28efc6d3 - window.blp: sets header_bar style main-headerbar-settings as default</li><li>0da0edea - Viewport: adds on_spinner_visible_changed callback</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/50/diffs?diff_id=1746756704&start_sha=6924ba68dfd66a8064a2b3a48051f8461e572b9b)

tarmaciltur commented 2026-04-22 17:15:33 -03:00 (Migrated from gitlab.com)

Copy link

me neither. I think we can merge this

me neither. I think we can merge this

tarmaciltur commented 2026-04-22 17:18:48 -03:00 (Migrated from gitlab.com)

Copy link

resolved all threads

resolved all threads

tarmaciltur commented 2026-04-22 17:18:56 -03:00 (Migrated from gitlab.com)

Copy link

marked this merge request as ready

marked this merge request as **ready**

tarmaciltur commented 2026-04-22 17:19:01 -03:00 (Migrated from gitlab.com)

Copy link

added 4 commits

• 6774e6ba - 1 commit from branch master
• d93d446f - window.vala: adds change_top_bar_style method
• 6206f870 - window.blp: sets header_bar style main-headerbar-settings as default
• e85c7523 - Viewport: adds on_spinner_visible_changed callback

Compare with previous version

added 4 commits <ul><li>6774e6ba - 1 commit from branch <code>master</code></li><li>d93d446f - window.vala: adds change_top_bar_style method</li><li>6206f870 - window.blp: sets header_bar style main-headerbar-settings as default</li><li>e85c7523 - Viewport: adds on_spinner_visible_changed callback</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/50/diffs?diff_id=1764120543&start_sha=0da0edeaaff048715827cb2e35a2039125f94783)

tarmaciltur (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2026-04-22 17:19:04 -03:00

tarmaciltur commented 2026-04-22 17:21:40 -03:00 (Migrated from gitlab.com)

Copy link

mentioned in commit 56622d67a0

mentioned in commit 56622d67a08f908f2c813b842659d82621e94972

tarmaciltur (Migrated from gitlab.com) merged commit 56622d67a0 into master 2026-04-22 17:21:40 -03:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Bug

  

Enhancement

  

Feature

  

needs design

No labels

Bug

Enhancement

Feature

needs design

Milestone

Clear milestone

No items

No milestone

First stable release

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

p/vigilantear!97

No description provided.