p/vigilantear
p/vigilantear
2
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Resolve "Change to next and previous cameras using keyboard shortcuts" #93

Merged
ariktaurendil merged 22 commits from 38-change-to-next-and-previous-cameras-using-keyboard-shortcuts into master 2026-04-22 17:52:15 -03:00
Conversation 18 Commits 22 Files changed 5 +109 -10
ariktaurendil commented 2026-04-10 22:30:56 -03:00 (Migrated from gitlab.com)
Copy link

Closes #38

Closes #38
ariktaurendil commented 2026-04-10 22:30:56 -03:00 (Migrated from gitlab.com)
Copy link

requested review from @tarmaciltur

requested review from @tarmaciltur
ariktaurendil commented 2026-04-10 22:30:56 -03:00 (Migrated from gitlab.com)
Copy link

assigned to @ariktaurendil

assigned to @ariktaurendil
ariktaurendil commented 2026-04-10 22:36:37 -03:00 (Migrated from gitlab.com)
Copy link

added 15 commits

  • 5f505428...93fc0a35 - 5 earlier commits
  • eed56b2b - application.vala: adds method on_clicked_previous_camera_button
  • ffaa4977 - application.vala: adds method on_clicked_next_camera_button
  • fdd44081 - application.vala: adds previous-camera action
  • 6d5e6687 - application.vala: adds next-camera action
  • cc898488 - application.vala: adds previous-camera shortcut
  • cafd4fef - application.vala: adds next-camera shortcut
  • c09b9146 - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem
  • e255fac7 - shortcuts-dialog.vala: adds next-camera action ShortcutsItem
  • 16c9b346 - vigilantear.pot: updates pot file.
  • c7fe0b79 - es.po: updates spanish translation

Compare with previous version

added 15 commits <ul><li>5f505428...93fc0a35 - 5 earlier commits</li><li>eed56b2b - application.vala: adds method on_clicked_previous_camera_button</li><li>ffaa4977 - application.vala: adds method on_clicked_next_camera_button</li><li>fdd44081 - application.vala: adds previous-camera action</li><li>6d5e6687 - application.vala: adds next-camera action</li><li>cc898488 - application.vala: adds previous-camera shortcut</li><li>cafd4fef - application.vala: adds next-camera shortcut</li><li>c09b9146 - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem</li><li>e255fac7 - shortcuts-dialog.vala: adds next-camera action ShortcutsItem</li><li>16c9b346 - vigilantear.pot: updates pot file.</li><li>c7fe0b79 - es.po: updates spanish translation</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1745929360&start_sha=5f5054282a6f8f255f6506f16111322e0658a38f)
ariktaurendil commented 2026-04-10 22:38:51 -03:00 (Migrated from gitlab.com)
Copy link

marked this merge request as ready

marked this merge request as **ready**
ariktaurendil commented 2026-04-11 15:47:02 -03:00 (Migrated from gitlab.com)
Copy link

added 25 commits

  • c7fe0b79...7ff98fac - 10 commits from branch master
  • 7ff98fac...a12ba73e - 5 earlier commits
  • f1d42394 - application.vala: adds method on_clicked_previous_camera_button
  • e776c6e7 - application.vala: adds method on_clicked_next_camera_button
  • 74ecdc11 - application.vala: adds previous-camera action
  • 0dfc239a - application.vala: adds next-camera action
  • ee231d15 - application.vala: adds previous-camera shortcut
  • 51b24608 - application.vala: adds next-camera shortcut
  • c8af39ea - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem
  • 423d4cab - shortcuts-dialog.vala: adds next-camera action ShortcutsItem
  • b4f05d40 - vigilantear.pot: updates pot file.
  • 2edb156a - es.po: updates spanish translation

Compare with previous version

added 25 commits <ul><li>c7fe0b79...7ff98fac - 10 commits from branch <code>master</code></li><li>7ff98fac...a12ba73e - 5 earlier commits</li><li>f1d42394 - application.vala: adds method on_clicked_previous_camera_button</li><li>e776c6e7 - application.vala: adds method on_clicked_next_camera_button</li><li>74ecdc11 - application.vala: adds previous-camera action</li><li>0dfc239a - application.vala: adds next-camera action</li><li>ee231d15 - application.vala: adds previous-camera shortcut</li><li>51b24608 - application.vala: adds next-camera shortcut</li><li>c8af39ea - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem</li><li>423d4cab - shortcuts-dialog.vala: adds next-camera action ShortcutsItem</li><li>b4f05d40 - vigilantear.pot: updates pot file.</li><li>2edb156a - es.po: updates spanish translation</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1746220365&start_sha=c7fe0b79eefc0ca9852a563e3adc147afa210c06)
tarmaciltur commented 2026-04-11 18:27:49 -03:00 (Migrated from gitlab.com)
Copy link

These two methods are the same

These two methods are the same
tarmaciltur commented 2026-04-11 18:27:50 -03:00 (Migrated from gitlab.com)
Copy link

left review comments

left review comments
ariktaurendil commented 2026-04-12 16:05:30 -03:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 78342139 - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names

Compare with previous version

added 1 commit <ul><li>78342139 - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1746597929&start_sha=2edb156aad13650aa754da01a150820c7e4788c2)
ariktaurendil commented 2026-04-12 16:10:00 -03:00 (Migrated from gitlab.com)
Copy link

Fixed in 78342139

My mistake, I didn't push this patch.

Fixed in 78342139 My mistake, I didn't push this patch.
ariktaurendil commented 2026-04-12 16:10:01 -03:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
ariktaurendil commented 2026-04-12 22:36:01 -03:00 (Migrated from gitlab.com)
Copy link

added 18 commits

  • 78342139...7a7b0eb4 - 2 commits from branch master
  • 7a7b0eb4...179ce216 - 6 earlier commits
  • 3881a914 - application.vala: adds method on_clicked_next_camera_button
  • d664221c - application.vala: adds previous-camera action
  • 1aebfed0 - application.vala: adds next-camera action
  • 967f891d - application.vala: adds previous-camera shortcut
  • ff461028 - application.vala: adds next-camera shortcut
  • 08c5e89e - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem
  • d50aecb4 - shortcuts-dialog.vala: adds next-camera action ShortcutsItem
  • 3e5fc98d - vigilantear.pot: updates pot file.
  • dc122ddb - es.po: updates spanish translation
  • 6523800e - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names

Compare with previous version

added 18 commits <ul><li>78342139...7a7b0eb4 - 2 commits from branch <code>master</code></li><li>7a7b0eb4...179ce216 - 6 earlier commits</li><li>3881a914 - application.vala: adds method on_clicked_next_camera_button</li><li>d664221c - application.vala: adds previous-camera action</li><li>1aebfed0 - application.vala: adds next-camera action</li><li>967f891d - application.vala: adds previous-camera shortcut</li><li>ff461028 - application.vala: adds next-camera shortcut</li><li>08c5e89e - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem</li><li>d50aecb4 - shortcuts-dialog.vala: adds next-camera action ShortcutsItem</li><li>3e5fc98d - vigilantear.pot: updates pot file.</li><li>dc122ddb - es.po: updates spanish translation</li><li>6523800e - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1746735450&start_sha=783421390f5a1f6c1a92cbc33495fff1ea60f383)
tarmaciltur commented 2026-04-22 12:47:20 -03:00 (Migrated from gitlab.com)
Copy link

added 17 commits

  • 6774e6ba - 1 commit from branch master
  • 6774e6ba...cb350bcf - 6 earlier commits
  • 1ea470b0 - application.vala: adds method on_clicked_next_camera_button
  • 68a88546 - application.vala: adds previous-camera action
  • b1b30614 - application.vala: adds next-camera action
  • 9a987fda - application.vala: adds previous-camera shortcut
  • f1bf9fd8 - application.vala: adds next-camera shortcut
  • 7e65a18a - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem
  • df874654 - shortcuts-dialog.vala: adds next-camera action ShortcutsItem
  • d692e5bd - vigilantear.pot: updates pot file.
  • a9fd0b80 - es.po: updates spanish translation
  • 836acd0e - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names

Compare with previous version

added 17 commits <ul><li>6774e6ba - 1 commit from branch <code>master</code></li><li>6774e6ba...cb350bcf - 6 earlier commits</li><li>1ea470b0 - application.vala: adds method on_clicked_next_camera_button</li><li>68a88546 - application.vala: adds previous-camera action</li><li>b1b30614 - application.vala: adds next-camera action</li><li>9a987fda - application.vala: adds previous-camera shortcut</li><li>f1bf9fd8 - application.vala: adds next-camera shortcut</li><li>7e65a18a - shortcuts-dialog.vala: adds previous-camera action ShortcutsItem</li><li>df874654 - shortcuts-dialog.vala: adds next-camera action ShortcutsItem</li><li>d692e5bd - vigilantear.pot: updates pot file.</li><li>a9fd0b80 - es.po: updates spanish translation</li><li>836acd0e - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1763678407&start_sha=6523800e092b54e3e10d33233f8181f4924ae94a)
ariktaurendil commented 2026-04-22 13:10:21 -03:00 (Migrated from gitlab.com)
Copy link

marked this merge request as draft

marked this merge request as **draft**
ariktaurendil commented 2026-04-22 13:14:37 -03:00 (Migrated from gitlab.com)
Copy link

I marked this as draft again, since I found that cursors won't work in entries in settings page.

I marked this as draft again, since I found that cursors won't work in entries in settings page.
ariktaurendil commented 2026-04-22 17:24:54 -03:00 (Migrated from gitlab.com)
Copy link

added 6 commits

  • a6d9b140 - window.vala: adds main_stack_page_changed public signal
  • 57f76576 - window.vala: adds emit main_stack_page_changed in set_visible_settings_page
  • 9d6940b1 - window.vala: adds emit main_stack_page_changed in set_visible_camera_page
  • a80374d8 - application.vala connect to window.main_stack_page_changed signal
  • 48456ae1 - window.vala: renames on_clicked_previous_camera_button to change_to_previous_camera
  • ac30a51e - window.vala: renames on_clicked_next_camera_button to change_to_next_camera

Compare with previous version

added 6 commits <ul><li>a6d9b140 - window.vala: adds main_stack_page_changed public signal</li><li>57f76576 - window.vala: adds emit main_stack_page_changed in set_visible_settings_page</li><li>9d6940b1 - window.vala: adds emit main_stack_page_changed in set_visible_camera_page</li><li>a80374d8 - application.vala connect to window.main_stack_page_changed signal</li><li>48456ae1 - window.vala: renames on_clicked_previous_camera_button to change_to_previous_camera</li><li>ac30a51e - window.vala: renames on_clicked_next_camera_button to change_to_next_camera</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1764128246&start_sha=836acd0ebd6386ea8a669a802f6fdc8df7fd0ec6)
ariktaurendil commented 2026-04-22 17:25:43 -03:00 (Migrated from gitlab.com)
Copy link

marked this merge request as ready

marked this merge request as **ready**
ariktaurendil commented 2026-04-22 17:49:29 -03:00 (Migrated from gitlab.com)
Copy link

added 26 commits

  • ac30a51e...56622d67 - 4 commits from branch master
  • 56622d67...3e1e9a52 - 12 earlier commits
  • 6ff6fdbd - shortcuts-dialog.vala: adds next-camera action ShortcutsItem
  • cc3a8566 - vigilantear.pot: updates pot file.
  • bf8e1f63 - es.po: updates spanish translation
  • ea59bb32 - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names
  • 75234423 - window.vala: adds main_stack_page_changed public signal
  • a2fa5553 - window.vala: adds emit main_stack_page_changed in set_visible_settings_page
  • c03451c5 - window.vala: adds emit main_stack_page_changed in set_visible_camera_page
  • ce257283 - application.vala connect to window.main_stack_page_changed signal
  • 98433ec7 - window.vala: renames on_clicked_previous_camera_button to change_to_previous_camera
  • b1b561ae - window.vala: renames on_clicked_next_camera_button to change_to_next_camera

Compare with previous version

added 26 commits <ul><li>ac30a51e...56622d67 - 4 commits from branch <code>master</code></li><li>56622d67...3e1e9a52 - 12 earlier commits</li><li>6ff6fdbd - shortcuts-dialog.vala: adds next-camera action ShortcutsItem</li><li>cc3a8566 - vigilantear.pot: updates pot file.</li><li>bf8e1f63 - es.po: updates spanish translation</li><li>ea59bb32 - window.vala: makes on_clicked_next_camera_button more robust and fix wrong variables names</li><li>75234423 - window.vala: adds main_stack_page_changed public signal</li><li>a2fa5553 - window.vala: adds emit main_stack_page_changed in set_visible_settings_page</li><li>c03451c5 - window.vala: adds emit main_stack_page_changed in set_visible_camera_page</li><li>ce257283 - application.vala connect to window.main_stack_page_changed signal</li><li>98433ec7 - window.vala: renames on_clicked_previous_camera_button to change_to_previous_camera</li><li>b1b561ae - window.vala: renames on_clicked_next_camera_button to change_to_next_camera</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/46/diffs?diff_id=1764191387&start_sha=ac30a51e372b2158f9c54b9bfca5410545146344)
tarmaciltur (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2026-04-22 17:50:45 -03:00
tarmaciltur commented 2026-04-22 17:52:15 -03:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 86131c310e

mentioned in commit 86131c310e043ef32a010566e7b6344f2e535a87
tarmaciltur (Migrated from gitlab.com) merged commit 86131c310e into master 2026-04-22 17:52:15 -03:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature

   
needs design
No labels
Bug
Enhancement
Feature
needs design
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/vigilantear!93
No description provided.