Resolve "Minor GUI issues" #69

Merged
ariktaurendil merged 23 commits from 16-minor-gui-issues into master 2026-03-01 16:46:17 -03:00
ariktaurendil commented 2026-02-28 19:19:42 -03:00 (Migrated from gitlab.com)

Closes #16

Closes #16
ariktaurendil commented 2026-02-28 19:19:42 -03:00 (Migrated from gitlab.com)

requested review from @tarmaciltur

requested review from @tarmaciltur
ariktaurendil commented 2026-02-28 19:19:42 -03:00 (Migrated from gitlab.com)

assigned to @ariktaurendil

assigned to @ariktaurendil
tarmaciltur (Migrated from gitlab.com) approved these changes 2026-02-28 19:19:42 -03:00
ariktaurendil commented 2026-02-28 21:32:40 -03:00 (Migrated from gitlab.com)

added 9 commits

  • 3be8256f - window.blp: max and min sidebar width to overlay_split_view
  • eeee8aea - window.blp: adds sidebar_scrolled_window name
  • 6acc89d1 - window.blp: remove width-request from sidebar_scrolled_window
  • 9f471a14 - window.blp: add Adw.Breakpoint to set width-request of sidebar_scrolled_window
  • 37c5040e - viewport.blp: sets picture's height-request
  • 31eab681 - window.vala: set show_sidebar_button not focusable on set_visible_settings_page
  • 70ff40a3 - window.vala: set savebutton focusable on set_visible_settings_page
  • e69bf230 - window.vala: set save_button not focusable on set_visible_camera_page
  • 372cdbf4 - window.vala: set show_sidebar_button focusable on set_visible_camera_page

Compare with previous version

added 9 commits <ul><li>3be8256f - window.blp: max and min sidebar width to overlay_split_view</li><li>eeee8aea - window.blp: adds sidebar_scrolled_window name</li><li>6acc89d1 - window.blp: remove width-request from sidebar_scrolled_window</li><li>9f471a14 - window.blp: add Adw.Breakpoint to set width-request of sidebar_scrolled_window</li><li>37c5040e - viewport.blp: sets picture&#39;s height-request</li><li>31eab681 - window.vala: set show_sidebar_button not focusable on set_visible_settings_page</li><li>70ff40a3 - window.vala: set savebutton focusable on set_visible_settings_page</li><li>e69bf230 - window.vala: set save_button not focusable on set_visible_camera_page</li><li>372cdbf4 - window.vala: set show_sidebar_button focusable on set_visible_camera_page</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/22/diffs?diff_id=1685735528&start_sha=5a15bab669aba4cae022055d05f4e1c955bbfe11)
tarmaciltur commented 2026-03-01 00:28:27 -03:00 (Migrated from gitlab.com)

approved this merge request

approved this merge request
ariktaurendil commented 2026-03-01 13:14:41 -03:00 (Migrated from gitlab.com)

added 12 commits

  • 372cdbf4...ad7c7b41 - 2 earlier commits
  • e72e03eb - viewport.vala: adds child spinner
  • 0d7662a4 - viewport.vala: adds set_paintable_hide_spinner method
  • af0c0448 - viewport.vala: set_renderer uses set_paintable_hide_spinner method
  • 562c99d4 - viewport.vala: as_card constructor uses set_paintable_hide_spinner method
  • 79d430d3 - vigilantear.css: adds class .camera-name
  • 3780c59a - viewport.blp: adds camera-name style to camera_name_label
  • cb78b09e - ar.com.softwareperonista.Vigilantear-symbolic.svg: add symbolic icon
  • 1c44267d - window.blp: adjusts Adw.Breakpoint threshold
  • ede42149 - window.vala: adds child sidebar_scrolled_window
  • 440b350f - window.vala: on_clicked_camera now goes hide diebar state if Adw.Breakpoint is active.

Compare with previous version

added 12 commits <ul><li>372cdbf4...ad7c7b41 - 2 earlier commits</li><li>e72e03eb - viewport.vala: adds child spinner</li><li>0d7662a4 - viewport.vala: adds set_paintable_hide_spinner method</li><li>af0c0448 - viewport.vala: set_renderer uses set_paintable_hide_spinner method</li><li>562c99d4 - viewport.vala: as_card constructor uses set_paintable_hide_spinner method</li><li>79d430d3 - vigilantear.css: adds class .camera-name</li><li>3780c59a - viewport.blp: adds camera-name style to camera_name_label</li><li>cb78b09e - ar.com.softwareperonista.Vigilantear-symbolic.svg: add symbolic icon</li><li>1c44267d - window.blp: adjusts Adw.Breakpoint threshold</li><li>ede42149 - window.vala: adds child sidebar_scrolled_window</li><li>440b350f - window.vala: on_clicked_camera now goes hide diebar state if Adw.Breakpoint is active.</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/22/diffs?diff_id=1685903485&start_sha=372cdbf45835276c34d43c6a4e5b65bee1ce2ec8)
ariktaurendil commented 2026-03-01 14:08:50 -03:00 (Migrated from gitlab.com)

added 1 commit

  • 52a9b831 - viewport.blp: minor indent change in camera_name_label

Compare with previous version

added 1 commit <ul><li>52a9b831 - viewport.blp: minor indent change in camera_name_label</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/22/diffs?diff_id=1685916979&start_sha=ab6fefb4cb6c3d8782fe89ab7e53b2844cf71431)
ariktaurendil commented 2026-03-01 14:09:06 -03:00 (Migrated from gitlab.com)

marked this merge request as ready

marked this merge request as **ready**
tarmaciltur commented 2026-03-01 14:10:01 -03:00 (Migrated from gitlab.com)

unapproved this merge request

unapproved this merge request
tarmaciltur commented 2026-03-01 14:10:03 -03:00 (Migrated from gitlab.com)

approved this merge request

approved this merge request
tarmaciltur commented 2026-03-01 14:10:54 -03:00 (Migrated from gitlab.com)

LGTM

LGTM
ariktaurendil (Migrated from gitlab.com) merged commit c063d43a66 into master 2026-03-01 16:46:17 -03:00
ariktaurendil commented 2026-03-01 16:46:18 -03:00 (Migrated from gitlab.com)

mentioned in commit c063d43a66

mentioned in commit c063d43a66078fb3599e6032e84ad6cfb115ee77
Sign in to join this conversation.
No reviewers
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/vigilantear!69
No description provided.