p/vigilantear
p/vigilantear
2
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Resolve "Persist camera configuration" #57

Merged
tarmaciltur merged 10 commits from 3-persist-camera-configuration into master 2026-02-18 23:12:04 -03:00
Conversation 23 Commits 10 Files changed 7 +144 -21
tarmaciltur commented 2026-02-17 21:29:27 -03:00 (Migrated from gitlab.com)
Copy link

Closes #3

Closes #3
tarmaciltur commented 2026-02-17 21:29:27 -03:00 (Migrated from gitlab.com)
Copy link

requested review from @ariktaurendil

requested review from @ariktaurendil
tarmaciltur commented 2026-02-17 21:29:27 -03:00 (Migrated from gitlab.com)
Copy link

assigned to @tarmaciltur

assigned to @tarmaciltur
ariktaurendil (Migrated from gitlab.com) approved these changes 2026-02-17 21:29:27 -03:00
tarmaciltur commented 2026-02-17 21:30:53 -03:00 (Migrated from gitlab.com)
Copy link

added 8 commits

  • 358d4390 - 1 commit from branch master
  • b081c484 - Renames proto methods and fields to protocol
  • 5c6ab170 - Camera: Changes return type of get_codec_name() to string
  • 756de6fe - Camera: Changes CameraRtsp case in get_camera_type_name()
  • 40b99f08 - Camera: Adds support export and import from KeyFile
  • 19e6e250 - CameraRtsp: Adds support export and import from KeyFile
  • 645c022b - Configuration: Adds a class to save and load camera
  • bf0c3bc4 - Window: Save and load camera

Compare with previous version

added 8 commits <ul><li>358d4390 - 1 commit from branch <code>master</code></li><li>b081c484 - Renames proto methods and fields to protocol</li><li>5c6ab170 - Camera: Changes return type of get_codec_name() to string</li><li>756de6fe - Camera: Changes CameraRtsp case in get_camera_type_name()</li><li>40b99f08 - Camera: Adds support export and import from KeyFile</li><li>19e6e250 - CameraRtsp: Adds support export and import from KeyFile</li><li>645c022b - Configuration: Adds a class to save and load camera</li><li>bf0c3bc4 - Window: Save and load camera</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/10/diffs?diff_id=1670667699&start_sha=f49b229852554b53500469af27dc3a50f97eb57d)
ariktaurendil commented 2026-02-17 22:24:35 -03:00 (Migrated from gitlab.com)
Copy link

This line throws a critical in the terminal.

GLib-CRITICAL **: 22:17:43.489: g_key_file_set_string: assertion 'string != NULL' failed
This line throws a critical in the terminal. ```bash GLib-CRITICAL **: 22:17:43.489: g_key_file_set_string: assertion 'string != NULL' failed ```
ariktaurendil commented 2026-02-17 22:24:35 -03:00 (Migrated from gitlab.com)
Copy link

This should be in a method that also updates the values in the widget of settings page.

This should be in a method that also updates the values in the widget of settings page.
ariktaurendil commented 2026-02-17 22:24:35 -03:00 (Migrated from gitlab.com)
Copy link

It looks really good. Address the comments I left for you and I think it's ready for merge.

It looks really good. Address the comments I left for you and I think it's ready for merge.
ariktaurendil commented 2026-02-17 22:24:36 -03:00 (Migrated from gitlab.com)
Copy link

requested changes

requested changes
tarmaciltur commented 2026-02-18 00:04:05 -03:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 4a2257b8 - Camera: Update camera type name retrieval to use `VigilantearCameraRtsp` and...

Compare with previous version

added 1 commit <ul><li>4a2257b8 - Camera: Update camera type name retrieval to use `VigilantearCameraRtsp` and...</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/10/diffs?diff_id=1670751212&start_sha=bf0c3bc49999af0c4766fda4a335f0560f8b5a3e)
tarmaciltur commented 2026-02-18 00:05:31 -03:00 (Migrated from gitlab.com)
Copy link

We should move the camera logic to another widget. But for this MR I think this line it's ok

We should move the camera logic to another widget. But for this MR I think this line it's ok
tarmaciltur commented 2026-02-18 00:05:31 -03:00 (Migrated from gitlab.com)
Copy link

left review comments

left review comments
tarmaciltur commented 2026-02-18 00:05:45 -03:00 (Migrated from gitlab.com)
Copy link

fixed

fixed
ariktaurendil commented 2026-02-18 00:23:30 -03:00 (Migrated from gitlab.com)
Copy link

Now, when you load the camera, the information of the camera is no updated in the settings page.

Now, when you load the camera, the information of the camera is no updated in the settings page.
tarmaciltur commented 2026-02-18 01:00:14 -03:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 2ff76b51 - Window: Load camera settings into the UI fields.

Compare with previous version

added 1 commit <ul><li>2ff76b51 - Window: Load camera settings into the UI fields.</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/10/diffs?diff_id=1670774613&start_sha=4a2257b84ba4aea06611b2eaf6d7dd78eaafcf7b)
tarmaciltur commented 2026-02-18 01:00:50 -03:00 (Migrated from gitlab.com)
Copy link

fixed

fixed
tarmaciltur commented 2026-02-18 01:00:51 -03:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
ariktaurendil commented 2026-02-18 22:06:45 -03:00 (Migrated from gitlab.com)
Copy link

No new line at the end of file.

No new line at the end of file.
ariktaurendil commented 2026-02-18 22:06:48 -03:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
tarmaciltur commented 2026-02-18 23:11:28 -03:00 (Migrated from gitlab.com)
Copy link
}
```suggestion:-0+0 } ```
tarmaciltur commented 2026-02-18 23:11:35 -03:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
tarmaciltur commented 2026-02-18 23:11:37 -03:00 (Migrated from gitlab.com)
Copy link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/softwareperonista/vigilantear/-/merge_requests/10/diffs?diff_id=1672643309&start_sha=2ff76b516befe09cd32181a4e34ec37fdb19d6d0#3355bf00ddd707924433b9310c4a1a9c4ee047db_208_208)
tarmaciltur commented 2026-02-18 23:11:38 -03:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • e5974e9a - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

added 1 commit <ul><li>e5974e9a - Apply 1 suggestion(s) to 1 file(s)</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/10/diffs?diff_id=1672643309&start_sha=2ff76b516befe09cd32181a4e34ec37fdb19d6d0)
tarmaciltur commented 2026-02-18 23:12:05 -03:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 057afffeed

mentioned in commit 057afffeed38b64247b5697c4c9d3a0ecd9f5c3d
tarmaciltur (Migrated from gitlab.com) merged commit 057afffeed into master 2026-02-18 23:12:05 -03:00
Sign in to join this conversation.
Reviewers
No reviewers
ariktaurendil
Labels
Clear labels   
Bug

   
Enhancement

   
Feature

   
needs design
No labels
Bug
Enhancement
Feature
needs design
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/vigilantear!57
No description provided.