p/vigilantear
p/vigilantear
2
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Wiki Activity Actions

Resolve "Camera configuration" #53

Merged
ariktaurendil merged 43 commits from 2-camera-configuration into master 2026-02-17 18:11:51 -03:00
Conversation 27 Commits 43 Files changed 3 +248 -10
ariktaurendil commented 2026-02-16 17:03:19 -03:00 (Migrated from gitlab.com)
Copy link

Closes #2

Closes #2
ariktaurendil commented 2026-02-16 17:03:19 -03:00 (Migrated from gitlab.com)
Copy link

requested review from @tarmaciltur

requested review from @tarmaciltur
ariktaurendil commented 2026-02-16 17:03:19 -03:00 (Migrated from gitlab.com)
Copy link

assigned to @ariktaurendil

assigned to @ariktaurendil
ariktaurendil commented 2026-02-16 20:27:43 -03:00 (Migrated from gitlab.com)
Copy link

added 5 commits

  • ee897b94 - VigilantearWindow: adds ViewStack widget
  • 0c83e3ca - VigilantearWindow: adds Settings buttojn to the HeaderBar
  • b86dd315 - VigilantearWindow: adds Settings page to the ViewStack
  • 0666ebb2 - VigilantearWindow: adds on_clicked_settings_button Callback method
  • 37a9325e - VigilantearWindow: adds rows to settings page

Compare with previous version

added 5 commits <ul><li>ee897b94 - VigilantearWindow: adds ViewStack widget</li><li>0c83e3ca - VigilantearWindow: adds Settings buttojn to the HeaderBar</li><li>b86dd315 - VigilantearWindow: adds Settings page to the ViewStack</li><li>0666ebb2 - VigilantearWindow: adds on_clicked_settings_button Callback method</li><li>37a9325e - VigilantearWindow: adds rows to settings page</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1668840823&start_sha=ecb6fdc52c3b561a60ca24d213c54df57cc86176)
ariktaurendil commented 2026-02-16 20:57:47 -03:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • ce3b19ac - window.blp: removes row for type in settings page

Compare with previous version

added 1 commit <ul><li>ce3b19ac - window.blp: removes row for type in settings page</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1668854399&start_sha=37a9325e33ca47cce65a4379ac471cfa955f0950)
tarmaciltur commented 2026-02-17 13:09:07 -03:00 (Migrated from gitlab.com)
Copy link

deleted the camera-model-from-cctv-watcher branch. This merge request now targets the master branch

deleted the `camera-model-from-cctv-watcher` branch. This merge request now targets the `master` branch
ariktaurendil commented 2026-02-17 13:10:39 -03:00 (Migrated from gitlab.com)
Copy link

added 3 commits

  • ece03c56 - window.vala: adds set_visible_settings_page method
  • ff0ca5ff - window.vala: adds set_visible_camera_page method
  • b3ad076b - window.vala: on_clicked_settings_button() now uses the especific methods.

Compare with previous version

added 3 commits <ul><li>ece03c56 - window.vala: adds set_visible_settings_page method</li><li>ff0ca5ff - window.vala: adds set_visible_camera_page method</li><li>b3ad076b - window.vala: on_clicked_settings_button() now uses the especific methods.</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1669980338&start_sha=ce3b19ac21aea0f5d08915329de55420f753e0b5)
ariktaurendil commented 2026-02-17 13:29:44 -03:00 (Migrated from gitlab.com)
Copy link

added 14 commits

  • b3ad076b...8b00855e - 5 commits from branch master
  • bad4450b - VigilantearWindow: adds ViewStack widget
  • ac5c8a32 - VigilantearWindow: adds Settings buttojn to the HeaderBar
  • 3a0332c7 - VigilantearWindow: adds Settings page to the ViewStack
  • 3072eaa5 - VigilantearWindow: adds on_clicked_settings_button Callback method
  • a804c60c - VigilantearWindow: adds rows to settings page
  • 58b535e9 - window.blp: removes row for type in settings page
  • a3f50568 - window.vala: adds set_visible_settings_page method
  • 364f31be - window.vala: adds set_visible_camera_page method
  • cdb379e7 - window.vala: on_clicked_settings_button() now uses the especific methods.

Compare with previous version

added 14 commits <ul><li>b3ad076b...8b00855e - 5 commits from branch <code>master</code></li><li>bad4450b - VigilantearWindow: adds ViewStack widget</li><li>ac5c8a32 - VigilantearWindow: adds Settings buttojn to the HeaderBar</li><li>3a0332c7 - VigilantearWindow: adds Settings page to the ViewStack</li><li>3072eaa5 - VigilantearWindow: adds on_clicked_settings_button Callback method</li><li>a804c60c - VigilantearWindow: adds rows to settings page</li><li>58b535e9 - window.blp: removes row for type in settings page</li><li>a3f50568 - window.vala: adds set_visible_settings_page method</li><li>364f31be - window.vala: adds set_visible_camera_page method</li><li>cdb379e7 - window.vala: on_clicked_settings_button() now uses the especific methods.</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1670016626&start_sha=b3ad076b26e94bae13818ee1694b5cdca3d88a8e)
ariktaurendil commented 2026-02-17 13:33:27 -03:00 (Migrated from gitlab.com)
Copy link

marked this merge request as ready

marked this merge request as **ready**
ariktaurendil commented 2026-02-17 13:34:04 -03:00 (Migrated from gitlab.com)
Copy link

@tarmaciltur you can review this one.

@tarmaciltur you can review this one.
tarmaciltur commented 2026-02-17 13:50:23 -03:00 (Migrated from gitlab.com)
Copy link

I think we should name this host

I think we should name this `host`
tarmaciltur commented 2026-02-17 13:50:23 -03:00 (Migrated from gitlab.com)
Copy link

Authorization should be related with username and password. Maybe those fields use the authorization value for enabled

Authorization should be related with username and password. Maybe those fields use the authorization value for enabled
tarmaciltur commented 2026-02-17 13:50:23 -03:00 (Migrated from gitlab.com)
Copy link

please add a method to set the camera when the camera page become visible.

please add a method to set the camera when the camera page become visible.
tarmaciltur commented 2026-02-17 13:50:24 -03:00 (Migrated from gitlab.com)
Copy link

left review comments

left review comments
ariktaurendil commented 2026-02-17 14:03:43 -03:00 (Migrated from gitlab.com)
Copy link

Ok, I thought that this would be out of scope, so I didn't include it in the MR.

Ok, I thought that this would be out of scope, so I didn't include it in the MR.
ariktaurendil commented 2026-02-17 16:32:36 -03:00 (Migrated from gitlab.com)
Copy link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1670292896&start_sha=cdb379e7848dd527c135da60a115aa55deb49868#c8defe29775fe5f98478b0ce82c7174ccc825a84_48_64)
ariktaurendil commented 2026-02-17 16:32:41 -03:00 (Migrated from gitlab.com)
Copy link

added 30 commits

  • cdb379e7...b7c59ef4 - 20 earlier commits
  • 033ff600 - camera_rtsp.vala: adds set_url_from_params method
  • 0b8ab858 - window.vala: sets save_button invisible on set_visible_camera_page method
  • 7d5bbecb - window.vala: sets save_button invisible on set_visible_settings_page method
  • 526adf61 - window.vala: adds show_camera method
  • 98f39c04 - window.vala: adds get_selected_codec method
  • b3df8bea - window.vala: adds get_selected_protocol method
  • b0e91a2e - window.vala: adds setup_camera method
  • 758aee9c - window.vala: adds on_clicked_save_button method
  • 56165d58 - window.vala: constructor now defaults to settings page if no camera is setted up
  • 7019f850 - window: adds on_changed_host_entry

Compare with previous version

added 30 commits <ul><li>cdb379e7...b7c59ef4 - 20 earlier commits</li><li>033ff600 - camera_rtsp.vala: adds set_url_from_params method</li><li>0b8ab858 - window.vala: sets save_button invisible on set_visible_camera_page method</li><li>7d5bbecb - window.vala: sets save_button invisible on set_visible_settings_page method</li><li>526adf61 - window.vala: adds show_camera method</li><li>98f39c04 - window.vala: adds get_selected_codec method</li><li>b3df8bea - window.vala: adds get_selected_protocol method</li><li>b0e91a2e - window.vala: adds setup_camera method</li><li>758aee9c - window.vala: adds on_clicked_save_button method</li><li>56165d58 - window.vala: constructor now defaults to settings page if no camera is setted up</li><li>7019f850 - window: adds on_changed_host_entry</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1670292896&start_sha=cdb379e7848dd527c135da60a115aa55deb49868)
ariktaurendil commented 2026-02-17 16:35:24 -03:00 (Migrated from gitlab.com)
Copy link

Fixed

Fixed
ariktaurendil commented 2026-02-17 16:35:36 -03:00 (Migrated from gitlab.com)
Copy link

Fixed

Fixed
ariktaurendil commented 2026-02-17 16:35:51 -03:00 (Migrated from gitlab.com)
Copy link

Fixed

Fixed
tarmaciltur commented 2026-02-17 17:23:45 -03:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
tarmaciltur commented 2026-02-17 17:24:20 -03:00 (Migrated from gitlab.com)
Copy link

Camera Name field is missing

Camera Name field is missing
ariktaurendil commented 2026-02-17 17:51:20 -03:00 (Migrated from gitlab.com)
Copy link

@tarmaciltur I need more context.

@tarmaciltur I need more context.
tarmaciltur commented 2026-02-17 17:57:33 -03:00 (Migrated from gitlab.com)
Copy link

Camera Name field is hardcoded. The user should set the name in camera configuration

https://gitlab.com/softwareperonista/vigilantear/-/merge_requests/6/diffs?commit_id=758aee9c260f95c8040a5f78ee98bf7ea76ed459#3355bf00ddd707924433b9310c4a1a9c4ee047db_129_133

Camera Name field is hardcoded. The user should set the name in camera configuration https://gitlab.com/softwareperonista/vigilantear/-/merge_requests/6/diffs?commit_id=758aee9c260f95c8040a5f78ee98bf7ea76ed459#3355bf00ddd707924433b9310c4a1a9c4ee047db_129_133
ariktaurendil commented 2026-02-17 18:03:13 -03:00 (Migrated from gitlab.com)
Copy link

added 4 commits

  • a4742425 - window.blp: adds name_entry to settings page.
  • db2750ec - window.vala: adds codec_entry class variable
  • 978076e4 - window.vala: passes entry_name setup_camera in on_clicked_save_button.
  • 6a242094 - window.vala: show_camera updates the window title this the name of the camera

Compare with previous version

added 4 commits <ul><li>a4742425 - window.blp: adds name_entry to settings page.</li><li>db2750ec - window.vala: adds codec_entry class variable</li><li>978076e4 - window.vala: passes entry_name setup_camera in on_clicked_save_button.</li><li>6a242094 - window.vala: show_camera updates the window title this the name of the camera</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/6/diffs?diff_id=1670429739&start_sha=7019f85003faf3cc9bd44fd4d2443555d8e16e8b)
ariktaurendil commented 2026-02-17 18:03:49 -03:00 (Migrated from gitlab.com)
Copy link

Done. Now, it also shows the camera name in the title of the window.

Done. Now, it also shows the camera name in the title of the window.
tarmaciltur commented 2026-02-17 18:09:12 -03:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
tarmaciltur (Migrated from gitlab.com) merged commit 358d43909b into master 2026-02-17 18:11:52 -03:00
tarmaciltur commented 2026-02-17 18:11:53 -03:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 358d43909b

mentioned in commit 358d43909bad0e2a52949d5dadff45eaaaadec2d
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature

   
needs design
No labels
Bug
Enhancement
Feature
needs design
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/vigilantear!53
No description provided.