124: Camera settings is now a PreferenceDialog #128

Merged

tarmaciltur merged 9 commits from 124-fix_expander_rows_nested_in_camera_settings into master 2026-05-25 16:02:16 -03:00

Conversation 1 Commits 9 Files changed 2 +110 -79

ariktaurendil commented 2026-05-24 23:28:02 -03:00

Owner

Copy link

This is the dialog that is shown when the user click on the camera settings row.

Closes #124

This is the dialog that is shown when the user click on the camera settings row.  Closes #124

Captura desde 2026-05-24 23-22-17-obfuscated.png

32 KiB

ariktaurendil added 9 commits 2026-05-24 23:28:02 -03:00

CameraSettings: changes inherit from Adw.ActionRow ac3b1375ac

camera_settings.blp: adds title to dialog_camera_details 6c6c26a48b

camera_settings.blp: adds Adw.PreferencesPage to dialog_camera_details ab771ab8d6

camera_settings.blp: format code in dialog_camera_details 98dc798135

camera_settings.blp: adds PreferenceGroup 9f01ecf061

camera_settings.blp: adds ExpanderRow url_entry 110e0aaf6f

camera_settings.vala: adds url related entries to url_row and on_url_rows_changed callback b5335913cb

camera_settings.blp: adds activatable true setting a047a9b49c

CameraSettings: adds on_activated_camera_row callback 34825d6f99

ariktaurendil requested review from tarmaciltur 2026-05-25 01:29:17 -03:00

ariktaurendil added this to the Second stable release milestone 2026-05-25 01:29:24 -03:00

ariktaurendil added the

Bug

label 2026-05-25 01:29:31 -03:00

ariktaurendil self-assigned this 2026-05-25 01:29:33 -03:00

tarmaciltur commented 2026-05-25 11:45:52 -03:00

Owner

Copy link

LGTM

LGTM

ariktaurendil force-pushed 124-fix_expander_rows_nested_in_camera_settings from 34825d6f99 to e967e83d83 2026-05-25 15:09:40 -03:00 Compare

tarmaciltur merged commit ef4fbb6291 into master 2026-05-25 16:02:16 -03:00

tarmaciltur deleted branch 124-fix_expander_rows_nested_in_camera_settings 2026-05-25 16:02:16 -03:00

tarmaciltur referenced this pull request from a commit 2026-05-25 16:02:16 -03:00

Merge pull request '124: Camera settings is now a PreferenceDialog' (#128) from 124-fix_expander_rows_nested_in_camera_settings into master

Sign in to join this conversation.

Reviewers

No reviewers

tarmaciltur

Labels

Clear labels   

Bug

  

Enhancement

  

Feature

  

Investigation

  

needs design

No labels

Bug

Enhancement

Feature

Investigation

needs design

Milestone

Clear milestone

No items

No milestone

Second stable release

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

ariktaurendil

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

p/vigilantear!128

No description provided.