Camera Order #118

Merged

tarmaciltur merged 5 commits from 17_camera_order into master 2026-05-23 15:06:54 -03:00

Conversation 3 Commits 5 Files changed 10 +186 -43

tarmaciltur commented 2026-05-16 01:26:45 -03:00

Owner

Copy link

Save and load the order of the cameras

Save and load the order of the cameras

tarmaciltur added 3 commits 2026-05-16 10:13:01 -03:00

Window: Refactors camera's loading process 11e7063dac

Camera: Adds order field 3a0e09258f

Window: Sort cameras by order c981681774

tarmaciltur added this to the Second stable release milestone 2026-05-16 10:16:55 -03:00

tarmaciltur self-assigned this 2026-05-16 10:16:59 -03:00

tarmaciltur requested review from ariktaurendil 2026-05-16 10:17:04 -03:00

tarmaciltur force-pushed 17_camera_order from c981681774 to 5e0686b2be 2026-05-16 10:24:26 -03:00 Compare

ariktaurendil commented 2026-05-16 17:00:30 -03:00

Owner

Copy link

Looks great! But I also have some issues.

• Maybe we can add some way to check the order values of other cameras. I think right now the user has to setup everything without any constraints. I not saying that it shouldn't be that way, it just I think we can think a solution for this.
• I think the order row shouldn't be visible if there is only one camera configured.

Looks great! But I also have some issues. - Maybe we can add some way to check the order values of other cameras. I think right now the user has to setup everything without any constraints. I not saying that it shouldn't be that way, it just I think we can think a solution for this. - I think the order row shouldn't be visible if there is only one camera configured.

ariktaurendil added the

Enhancement

label 2026-05-16 17:00:41 -03:00

tarmaciltur changed title from Camera Order to WIP: Camera Order 2026-05-16 18:37:48 -03:00

tarmaciltur force-pushed 17_camera_order from 5e0686b2be to 43672b6bba 2026-05-18 08:41:49 -03:00 Compare

tarmaciltur force-pushed 17_camera_order from 43672b6bba to 8695ef4b16 2026-05-18 21:16:51 -03:00 Compare

tarmaciltur commented 2026-05-18 21:36:08 -03:00

Author

Owner

Copy link

@ariktaurendil wrote in #118 (comment):

Looks great! But I also have some issues.

* Maybe we can add some way to check the order values of other cameras. I think right now the user has to setup everything without any constraints. I not saying that it shouldn't be that way, it just I think we can think a solution for this.

* I think the order row shouldn't be visible if there is only one camera configured.

Now the order is invisible when there is only one camera.

The order values check is somewhat complex and i'd rather implement it in other PR

@ariktaurendil wrote in https://softwareperonista.com.ar/p/vigilantear/pulls/118#issuecomment-1139: > Looks great! But I also have some issues. > > * Maybe we can add some way to check the order values of other cameras. I think right now the user has to setup everything without any constraints. I not saying that it shouldn't be that way, it just I think we can think a solution for this. > > * I think the order row shouldn't be visible if there is only one camera configured. Now the order is invisible when there is only one camera. The order values check is somewhat complex and i'd rather implement it in other PR

tarmaciltur changed title from WIP: Camera Order to Camera Order 2026-05-18 21:36:16 -03:00

ariktaurendil approved these changes 2026-05-23 13:52:42 -03:00

ariktaurendil left a comment

Copy link

LGTM

LGTM

tarmaciltur merged commit b7e2698455 into master 2026-05-23 15:06:54 -03:00

tarmaciltur deleted branch 17_camera_order 2026-05-23 15:06:54 -03:00

tarmaciltur referenced this pull request from a commit 2026-05-23 15:06:55 -03:00

Merge pull request 'Camera Order' (#118) from 17_camera_order into master

Sign in to join this conversation.

Reviewers

No reviewers

ariktaurendil

Labels

Clear labels   

Bug

  

Enhancement

  

Feature

  

Investigation

  

needs design

No labels

Bug

Enhancement

Feature

Investigation

needs design

Milestone

Clear milestone

No items

No milestone

Second stable release

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

tarmaciltur

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

p/vigilantear!118

No description provided.