Resolve "Volume toast should be in the viewport." #103

Merged
ariktaurendil merged 3 commits from 44-volume-toast-should-be-in-the-viewport into master 2026-05-01 01:52:27 -03:00
ariktaurendil commented 2026-04-27 17:34:26 -03:00 (Migrated from gitlab.com)

Closes #44

Closes #44
ariktaurendil commented 2026-04-27 17:34:27 -03:00 (Migrated from gitlab.com)

requested review from @tarmaciltur

requested review from @tarmaciltur
ariktaurendil commented 2026-04-27 17:34:27 -03:00 (Migrated from gitlab.com)

assigned to @ariktaurendil

assigned to @ariktaurendil
ariktaurendil commented 2026-04-27 17:41:01 -03:00 (Migrated from gitlab.com)

added 13 commits

  • f0ed998b...83b21121 - 3 earlier commits
  • 657978e2 - viewport.vala: adds dismiss_toast public method
  • 6d92a203 - viewport.vala: decrease_volume method uses show_toast method
  • 5dad1ec4 - viewport.vala: increase_volume method uses show_toast method
  • bbc59a5a - window.vala: on_up_volumen_button_pressed doesn't add a toast anymore.
  • 1de03f1d - window.vala: on_down_volumen_button_pressed doesn't add a toast anymore.
  • 5ac07618 - window.vala: changes name from picture_view_toast_overlay to main_toast_overlay
  • 7270a8eb - window.vala: adds dismiss_all_toasts method
  • e1c3a486 - window.vala: toggle_automatic_switch_cameras methos uses dismiss_all_toasts method
  • e543ec54 - window.vala: on_up_volumen_button_pressed method uses dismiss_all_toasts method
  • f5f0aa8f - window.vala: on_down_volumen_button_pressed method uses dismiss_all_toasts method

Compare with previous version

added 13 commits <ul><li>f0ed998b...83b21121 - 3 earlier commits</li><li>657978e2 - viewport.vala: adds dismiss_toast public method</li><li>6d92a203 - viewport.vala: decrease_volume method uses show_toast method</li><li>5dad1ec4 - viewport.vala: increase_volume method uses show_toast method</li><li>bbc59a5a - window.vala: on_up_volumen_button_pressed doesn&#39;t add a toast anymore.</li><li>1de03f1d - window.vala: on_down_volumen_button_pressed doesn&#39;t add a toast anymore.</li><li>5ac07618 - window.vala: changes name from picture_view_toast_overlay to main_toast_overlay</li><li>7270a8eb - window.vala: adds dismiss_all_toasts method</li><li>e1c3a486 - window.vala: toggle_automatic_switch_cameras methos uses dismiss_all_toasts method</li><li>e543ec54 - window.vala: on_up_volumen_button_pressed method uses dismiss_all_toasts method</li><li>f5f0aa8f - window.vala: on_down_volumen_button_pressed method uses dismiss_all_toasts method</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/56/diffs?diff_id=1771434752&start_sha=f0ed998bb874292133f32c2e58ed00a3d142fabe)
ariktaurendil commented 2026-04-27 21:44:30 -03:00 (Migrated from gitlab.com)

marked this merge request as ready

marked this merge request as **ready**
ariktaurendil commented 2026-04-28 12:08:03 -03:00 (Migrated from gitlab.com)

added 1 commit

  • 2bb7f216 - vindow.vala: volumen toast dismissed when vamera displayed change

Compare with previous version

added 1 commit <ul><li>2bb7f216 - vindow.vala: volumen toast dismissed when vamera displayed change</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/56/diffs?diff_id=1773044536&start_sha=f5f0aa8f7088381f31862b865568634785d3ffe1)
ariktaurendil commented 2026-04-28 12:11:35 -03:00 (Migrated from gitlab.com)

added 2 commits

  • c50051e1 - Update transaltion
  • c62286de - Updates spanish translation

Compare with previous version

added 2 commits <ul><li>c50051e1 - Update transaltion</li><li>c62286de - Updates spanish translation</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/56/diffs?diff_id=1773053915&start_sha=2bb7f2164354b320ca5ffb62947286063afc879e)
tarmaciltur commented 2026-05-01 01:50:00 -03:00 (Migrated from gitlab.com)

added 6 commits

  • c62286de...2faea5dc - 3 commits from branch master
  • fd570e74 - vindow.vala: volumen toast dismissed when vamera displayed change
  • 0946a1ff - Update transaltion
  • 3269b5a9 - Updates spanish translation

Compare with previous version

added 6 commits <ul><li>c62286de...2faea5dc - 3 commits from branch <code>master</code></li><li>fd570e74 - vindow.vala: volumen toast dismissed when vamera displayed change</li><li>0946a1ff - Update transaltion</li><li>3269b5a9 - Updates spanish translation</li></ul> [Compare with previous version](/softwareperonista/vigilantear/-/merge_requests/56/diffs?diff_id=1778184719&start_sha=c62286debdd2a05324a43b800d55185501425781)
tarmaciltur (Migrated from gitlab.com) merged commit 56d508ee6d into master 2026-05-01 01:52:27 -03:00
tarmaciltur commented 2026-05-01 01:52:28 -03:00 (Migrated from gitlab.com)

mentioned in commit 56d508ee6d

mentioned in commit 56d508ee6dc316ceaf7c00e3a93e0346ea0893d2
Sign in to join this conversation.
No reviewers
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/vigilantear!103
No description provided.