p/agenda-docente-backend
2
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Adds Student #7

Merged
tarmaciltur merged 2 commits from 5-adds-student into master 2026-07-12 14:15:51 -03:00
Conversation 2 Commits 2 Files changed 4 +203 -2
tarmaciltur commented 2026-07-10 18:25:41 -03:00
Owner
Copy link
No description provided.
ariktaurendil reviewed 2026-07-10 20:04:36 -03:00
ariktaurendil left a comment
Copy link

It works great. I only have tow concerns, the one I address in the comment and about names. Does first_name field is intended to be user to store all names of the student? If that's the case I would put some cue in the GUI.

It works great. I only have tow concerns, the one I address in the comment and about names. Does first_name field is intended to be user to store all names of the student? If that's the case I would put some cue in the GUI.
controllers/student.go
@ -0,0 +20,4 @@
}
// UpdateStudentInput represents payload to update a student
type UpdateStudentInput struct {
ariktaurendil commented 2026-07-10 19:38:36 -03:00
Owner
Copy link

CreateStudentInput and UpdateStudentInput are exactly the same. Couldn't they be just one StudentInput structure?

CreateStudentInput and UpdateStudentInput are exactly the same. Couldn't they be just one StudentInput structure?
tarmaciltur commented 2026-07-10 20:57:45 -03:00
Author
Owner
Copy link

Done

Done
tarmaciltur marked this conversation as resolved
ariktaurendil approved these changes 2026-07-10 21:34:04 -03:00
ariktaurendil left a comment
Copy link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No reviewers
ariktaurendil
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
p/agenda-docente-backend!7
No description provided.